fix: switch state sync when used inside a Portal on iOS#4818
Open
PaitoAnderson wants to merge 2 commits intocallstack:mainfrom
Open
fix: switch state sync when used inside a Portal on iOS#4818PaitoAnderson wants to merge 2 commits intocallstack:mainfrom
PaitoAnderson wants to merge 2 commits intocallstack:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Hey @PaitoAnderson, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
gkueny
reviewed
Oct 29, 2025
Comment on lines
+76
to
+80
| React.useEffect(() => { | ||
| if (typeof value === 'boolean' && value !== internalValue) { | ||
| setInternalValue(value); | ||
| } | ||
| }, [value, internalValue]); |
There was a problem hiding this comment.
Suggested change
| React.useEffect(() => { | |
| if (typeof value === 'boolean' && value !== internalValue) { | |
| setInternalValue(value); | |
| } | |
| }, [value, internalValue]); | |
| React.useEffect(() => { | |
| setInternalValue(oldValue => { | |
| if (typeof value === 'boolean' && value !== oldValue) { | |
| return value; | |
| } | |
| return oldValue; | |
| }); | |
| }, [value]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a
<Switch />is inside a<Portal />you must tap the switch component twice to visually toggle the state on iOS.Related issue
Fixes #4789
Test plan
I updated the example app to Expo 54, and then added this code in the
SwitchExample.tsxfile and tried toggling with a single tap.